Closed
Conversation
Contributor
|
Hi @ujjwalsh -- thank you for this PR! It does look good! This is not a platform that I have any hardware to test anything going forward. I am just curious what the context of this PR is so I can understand this better and learn something. I will merge this once I understand this a bit better. |
Contributor
|
@ujjwalsh -- I apologize for dropping the ball on this. I am about to migrate to using github actions, do you have a recommended approach to run this with github actions? I saw this: https://github.com/uraimo/run-on-arch-action. Should I use that? |
amd64 is covered by the github actions now.
Contributor
|
@ujjwalsh -- I just made a tiny change to remove amd64 and it looks like setting the permissions failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I had added ppc64le(Linux on Power) support on travis-ci in the branch and looks like its been successfully added. I believe it is ready for the final review and merge. The travis ci build logs can be verified from the link below.
https://travis-ci.com/github/ujjwalsh/cyarray/builds/185196442
Please have a look.
Regards,
ujjwal